Repository navigation
[Test Improver] test(shared): add 34 unit tests for CriteriaStore - #399
Open
Cedric Vidal (cedricvidal) wants to merge 1 commit into
Open
Cedric Vidal (cedricvidal) wants to merge 1 commit into
Cedric Vidal (cedricvidal) wants to merge 1 commit into
Conversation
Tests cover all public methods using an in-memory mock MongoDB collection (same pattern as task-prompt-store.test.ts): - getAll: empty, sorted, excludes soft-deleted - get: not found, by id, soft-deleted returns null - create: happy path, trim prompt, dependencies, invalid id format, duplicate id, nonexistent dep, cycle detection - update: prompt, trim, dependencies, not found, bad dep - delete: soft-delete, not found, blocks if dependents exist, allows when dependent is soft-deleted - resolveWithAncestors: single, transitive, diamond dedup, not found error, multiple starting criteria - getGraph: empty, nodes+edges, excludes soft-deleted - seed: insert new, skip existing, returns count Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Original author: @github-actions[bot] Test Results (Node.js 22)test: Run #346
🎉 All tests passed! |
This was referenced Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original author: Cedric Vidal (@cedricvidal)
Tests cover all public methods using an in-memory mock MongoDB collection (same pattern as task-prompt-store.test.ts):